In-tab notification bridge so the operator gets a system notification
when a reminder fires successfully (or partly / fails) and when a
send-test message lands. Foundation for true background push later
(VAPID + service-worker subscription); this lands the wiring so
behaviour is testable today.
Pieces
------
- `lib/notifications.ts` — pure helper module:
* notificationSupport / getPermission — feature detection that
treats the SSR / unsupported-browser case as "denied" so callers
don't have to handle a third state.
* isOptedIn / setOptedIn — localStorage-backed opt-in flag
(key `cmbot.notifications.optedIn`). Survives gracefully when
window is missing or storage throws (private mode / quota).
* showNotification(opts) — gated dispatch returning a discriminated
result ({ ok: true, tag } | { ok: false, reason }) so callers
can fall back to a UI toast on opt-out / unsupported / error.
* reminderFiredToNotification + sendTestDoneToNotification —
pure mappers from the bot's SSE events into notification args.
Skips bookkeeping noise (status === "skipped") and failures
that the in-page toast already shows verbatim.
- `components/notification-manager.tsx` — client component mounted
once at the app shell. Subscribes to `reminder.fired` and
`send_test.done` via useEvents and forwards each through the pure
mappers. Renders no DOM.
- `components/notifications-toggle.tsx` — settings-page card with
three states (unsupported / not-granted / granted+opted-in).
"Send test" button fires a sample notification so the operator
can verify the wiring without waiting for a real reminder. The
blocked-by-browser path points them at site settings instead of
silently doing nothing.
- `app/settings/page.tsx` — new "Notifications" card sits above
the Appearance card.
- `app/layout.tsx` — `<NotificationManager />` rendered alongside
`<Toaster />` inside ThemeProvider so the SSE subscription is
active across all routes.
Bot side
--------
- `apps/bot/src/scheduler/fire-reminder.ts` — emits
`pgNotifyWeb({ type: "reminder.fired", reminderId, runId, status })`
after every run regardless of success/partial/failed. The web
side decides whether to surface it as a notification (skipped is
filtered out client-side).
- send_test.done was already emitted by `ipc/send-test-handler.ts`.
PWA service-worker tests (the original ask before this thread)
--------------------------------------------------------------
- Extracted the Serwist config into `pwa/config.ts` so the choices
(skipWaiting, clientsClaim, navigationPreload, runtimeCaching,
precacheEntries) are pinnable without booting a worker scope.
- 6 tests in `pwa/config.test.ts` lock the surface (no extra keys
appear silently, the manifest passes through unchanged, the
pinned booleans stay where production expects them).
- 6 tests in `app/manifest.webmanifest/route.test.ts` cover the
manifest contract (display=standalone, start_url=/, dark theme
colors match the OS, both icons are PNG + maskable, paths
match committed PNGs in public/).
Test counts
-----------
281 web + 31 shared + 26 bot = 338 total (was 306).
- +6 pwa/config (service-worker config pinning)
- +6 app/manifest.webmanifest (PWA manifest contract)
- +20 lib/notifications (full coverage of mappers + dispatch
gates + SSR / unsupported / blocked / opted-out paths)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
115 lines
3.4 KiB
TypeScript
115 lines
3.4 KiB
TypeScript
"use client";
|
|
|
|
import { useEffect, useState } from "react";
|
|
import { BellIcon, BellOffIcon, AlertCircleIcon } from "lucide-react";
|
|
import { Button } from "@/components/ui/button";
|
|
import {
|
|
getPermission,
|
|
isOptedIn,
|
|
notificationSupport,
|
|
requestPermission,
|
|
setOptedIn,
|
|
showNotification,
|
|
type NotificationPermission,
|
|
} from "@/lib/notifications";
|
|
|
|
/**
|
|
* Settings-page card that lets the operator opt into browser
|
|
* notifications for "reminder fired" and "send-test sent" events.
|
|
*
|
|
* Three states the UI surfaces:
|
|
*
|
|
* 1. Not supported (server / older browser) — shows a one-line
|
|
* muted note. No action.
|
|
* 2. Permission not granted — Enable button asks the browser.
|
|
* If the user blocks the prompt we fall back to a
|
|
* "blocked in browser" note pointing them at site settings.
|
|
* 3. Granted + opted in — toggle to disable, plus a "Test"
|
|
* button that fires a sample notification so the operator
|
|
* knows the wiring works end-to-end.
|
|
*/
|
|
export function NotificationsToggle() {
|
|
const [supported, setSupported] = useState(false);
|
|
const [permission, setPermission] = useState<NotificationPermission>("default");
|
|
const [optedIn, setOptedInState] = useState(false);
|
|
const [busy, setBusy] = useState(false);
|
|
|
|
// Hydrate from the live browser state once on mount; the server
|
|
// can't know any of these values.
|
|
useEffect(() => {
|
|
setSupported(notificationSupport() === "supported");
|
|
setPermission(getPermission());
|
|
setOptedInState(isOptedIn());
|
|
}, []);
|
|
|
|
async function enable() {
|
|
setBusy(true);
|
|
const result = await requestPermission();
|
|
setPermission(result);
|
|
if (result === "granted") {
|
|
setOptedIn(true);
|
|
setOptedInState(true);
|
|
}
|
|
setBusy(false);
|
|
}
|
|
|
|
function disable() {
|
|
setOptedIn(false);
|
|
setOptedInState(false);
|
|
}
|
|
|
|
function fireTest() {
|
|
showNotification({
|
|
title: "Test notification",
|
|
body: "Notifications are wired up. Reminder runs and send-tests will surface here.",
|
|
tag: "settings-test",
|
|
});
|
|
}
|
|
|
|
if (!supported) {
|
|
return (
|
|
<div className="flex items-center gap-2 text-xs text-muted-foreground">
|
|
<BellOffIcon className="size-3.5 shrink-0" />
|
|
Notifications aren't supported by this browser.
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (permission === "denied") {
|
|
return (
|
|
<div className="flex items-start gap-2 text-xs text-muted-foreground">
|
|
<AlertCircleIcon className="size-3.5 shrink-0 mt-0.5" />
|
|
<span>
|
|
Notifications are blocked at the browser level. Enable them
|
|
in your site settings (lock icon next to the URL) and
|
|
reload.
|
|
</span>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
if (permission === "granted" && optedIn) {
|
|
return (
|
|
<div className="flex flex-wrap items-center gap-2">
|
|
<span className="inline-flex items-center gap-1.5 text-xs text-emerald-700 dark:text-emerald-400">
|
|
<BellIcon className="size-3.5" />
|
|
On
|
|
</span>
|
|
<Button type="button" size="sm" variant="outline" onClick={fireTest}>
|
|
Send test
|
|
</Button>
|
|
<Button type="button" size="sm" variant="ghost" onClick={disable}>
|
|
Turn off
|
|
</Button>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<Button type="button" size="sm" onClick={enable} disabled={busy} className="gap-1.5">
|
|
<BellIcon className="size-3.5" />
|
|
{busy ? "Asking…" : "Enable notifications"}
|
|
</Button>
|
|
);
|
|
}
|